Add pop-up when a WebAuthn credential is deleted #3708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! My one suggestion is perhaps adding a system test that clicks |
Codecov Report
@@ Coverage Diff @@
## master #3708 +/- ##
=======================================
Coverage 98.74% 98.75%
=======================================
Files 207 207
Lines 5115 5130 +15
=======================================
+ Hits 5051 5066 +15
Misses 64 64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
55f2f53 to
c81d0f7
Compare
Good call! Done ✅ |
c81d0f7 to
900ffd0
Compare
segiddins
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you solving?
When deleting a WebAuthn device, there should be a pop-up or alert to make sure that this action was not made by accident.
What approach did you choose and why?
Like when deleting an API key, added a confirmation associated with the delete button
What should reviewers focus on?
The phrasing of the confirmation message
Testing