-
-
Notifications
You must be signed in to change notification settings - Fork 968
Add mailer for WebAuthn credential updates #3695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but otherwise LGTM.
Codecov Report
@@ Coverage Diff @@
## master #3695 +/- ##
==========================================
+ Coverage 98.72% 98.75% +0.02%
==========================================
Files 204 207 +3
Lines 5022 5130 +108
==========================================
+ Hits 4958 5066 +108
Misses 64 64
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e0ed5ad
to
350c8fc
Compare
What problem a 8000 re you solving?
There aren't any emails sent when someone adds/removes a security device to their account. A user won't be notified if this was because the account was compromised.
What approach did you choose and why?
I added
webauthn_credential_created
andwebauthn_credential_removed
to the mailer and to the mailer preview.Testing
Device creation
Plain text
HTML
Device being removed
Plain text
HTML