[GSoC]Add autocompletion for search boxes #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
436eaa8 to
8d46600
Compare
sonalkr132
reviewed
Jul 8, 2019
sonalkr132
reviewed
Aug 12, 2019
There was a problem hiding this comment.
Thank for working on this @shunshunNi 💯 It is in working state, we need to make a few improvements.
| analyzer: { | ||
| rubygem: { | ||
| filter: { | ||
| autocomplete_ngram: { |
There was a problem hiding this comment.
Can you please share your findings related to ngram being faster than suggest API?
What was your method of testing this and how much miliseconds faster was ngram on your local setup?
There was a problem hiding this comment.
As I ran the test, I think the execution time is so small and it could be negligible. In addition, actually completion suggester seems faster. See my gist how I've collect a result.
https://gist.github.com/shunshunNi/81604414181a5ee69ae3f5f497791b2b
4c38eb1 to
ae798b9
Compare
ae798b9 to
365aac5
Compare
sonalkr132
reviewed
Aug 24, 2019
sonalkr132
reviewed
Aug 24, 2019
sonalkr132
reviewed
Aug 24, 2019
0e97c8d to
6da36b8
Compare
remove autocomplete from search controller change autocomplete function to plugin add sample test for autocomplete add autocomplete test add sources for CSP refactor autocomplete javascript improve autocomplete test fix style and CSP Add ctrl + n & p selecting in autocomplete Refactoring autocomplete.js refactoring autocomplete.js add chrome: stable to run travis-ci correctly refactor autocomplete.js add functional t 8000 ests for autocomplete api change method name suggest => suggestions add tests for suggestions in lib/elastic_searcher.rb change list name change autocomplete using ngram_edge to completion suggester fix mapping & analyzer error set before_action for autocomplete Pass api as an argument for search Move returning of gems name function from controller to model
6da36b8 to
2d1d3c9
Compare
we don't need binding on ctrl + p, n for selection. we don't need to preserve form input when looping over result. removed code related to these parts.
c75d259 to
eeb6b6d
Compare
eeb6b6d to
8b3db39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goal is to provide autocomplete function(incremental search) for search boxes.
Currently this branch has two main parts.
Using n-gram filter, "name" can be autocompleted.
Using JQuery autocomplete with the gem 'jquery-ui-rails' , autocompletion work for the search box on the top page.
There are some problems for my implementation. Please check to run the tests.
Sorry, I accidentally closed the PR.