Don't redirect dependency api endpoints to https on host insecure.rubygems.org #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14059d0 to
23fee24
Compare
…ygems.org We want to allow users to use `--source 'http://insecure.rubygems.org'` in cli and not have it redirect to https. It can be possible that user's host doesn't have openssl installed, which is required for https source. We use to support this on all domains before migrating to `config.ssl = true`.
23fee24 to
df14d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow users to use
--source 'http://insecure.rubygems.org'in cli (if they must) and not have it redirect to https. It can be possible that user's host doesn't have openssl installed, which is required for https source.We use to support this on all domains before migrating to
config.ssl = true.Related: #1083, ruby/rubygems#4192