Add basic auth to staging ui #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalkr132
commented
Aug 13, 2020
| "nginx-basic-auth": { | ||
| "_type": "Opaque", | ||
| "data": { | ||
| ".htpasswd": "EJ[1:MVylFycMlDK6oU5Jje1iXf6AMMiHkYAD5RnXlXfg5Fs=:YcD96nyUoPoeK9fJgh5Uj9oaKtx69HqV:tL7FPskgJqmU5hTYrL5kPwnTzC0gITPxGpswSrS4AihF5/96GbPqS97Fz/qNr6YUsO3d4IcfClvbHapUzc7mYeW4dTlf3Q==]" |
There was a problem hiding this comment.
"EJ[1:MVylFycMlDK6oU5Jje1iXf6AMMiHkYAD5RnXlXfg5Fs=:YcD96nyUoPoeK9fJgh5Uj9oaKtx69HqV:tL7.."
Note this has two : in the value as htpasswd file is of the format user:pass_hash. I am hoping ejson won't get confused.
indirect
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would very much prefer to load data-dump from prod in staging env. This would be very helpful in running rake tasks which need access to things like s3.
Some users seem to get confused when they see same gem on multiple site (rubgems.org and staging.rubygems.org). Adding basic auth to avoid this confusion.