Replace sass-rails with sassc-rails and don't install in prod image #2478

sonalkr132 · 2020-08-07T08:38:41Z

We precompile assets in build state and don't assets group installed in prod container.
bundle clean --force ensures gem not enabled are not installed on the host.

Reduces docker image size by almost 100 MB

$ sudo docker images | grep ruby
rubygems                latest              8b8dab70e1a1        19 minutes ago      273MB
rubygems-old            latest              f8777bb38d38        2 hoursago         371MB

Tested with force SSL config and Redirector middleware disabled

sudo docker run --net host  -e DATABASE_URL=postgresql://localhost -e RAILS_ENV=production -e SECRET_KEY_BASE=1234 -e RAILS_SERVE_STATIC_FILES=true rubygems -- unicorn_rails -E production -c /app/config/unicorn.conf

cc: @simi

sass-rails is just a rapper for sassc-rails.

We precompile assets in build state and don't need to install assets group in prod image. `bundle clean --force` ensures gem not enabled are not installed on the host. Reduces docker image size by almost 100 MB ``` $ sudo docker images | grep ruby rubygems latest 8b8dab70e1a1 19 minutes ago 273MB rubygems-old latest f8777bb38d38 2 hoursago 371MB ```

colby-swandale · 2020-08-17T13:11:30Z

Dockerfile

-RUN RAILS_ENV=production RAILS_GROUPS=js SECRET_KEY_BASE=1234 bin/rails assets:precompile
+RUN RAILS_ENV=production RAILS_GROUPS=assets SECRET_KEY_BASE=1234 bin/rails assets:precompile
+
+RUN bundle config set --local without 'development test assets' && \


Can this instead just be? :

RUN BUNDLE_WITHOUT="assets" bundle clean --force

None of the development/test gems are installed so setting the full bundle config.. again seems a bit unnecessary.

Hi, I tried this, didn't work for me. bundle config set by default sets local config and local config takes precedence over the env. I tried --global as well but didn't work either. Maybe you can give this a try?

so setting the full bundle config.. again seems a bit unnecessary.

internally both bundle config set without and BUNDLE_WITHOUT set up the value of the same setting Bundler.settings['without']. Perhaps using the same method to change the same setting make more sense?

I am moving ahead with this. Please free to update this if you can find a way do this without using bundle config set

sonalkr132 changed the title ~~Replace sass-rails with sassc-rails and don't install prod image~~ Replace sass-rails with sassc-rails and don't install in prod image Aug 7, 2020

sonalkr132 force-pushed the move-sassc branch from 003d4af to 5bbf702 Compare August 7, 2020 12:40

sonalkr132 added 2 commits August 8, 2020 10:16

Replace sass-rails with sassc-rails

b36774d

sass-rails is just a rapper for sassc-rails.

sonalkr132 force-pushed the move-sassc branch from 5bbf702 to 46d8eb6 Compare August 8, 2020 04:47

colby-swandale reviewed Aug 17, 2020

View reviewed changes

sonalkr132 merged commit 0414b00 into rubygems:master Oct 6, 2020

sonalkr132 deleted the move-sassc branch October 6, 2020 08:34

sonalkr132 temporarily deployed to staging October 7, 2020 05:30 Inactive

sonalkr132 temporarily deployed to production October 9, 2020 04:29 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Replace sass-rails with sassc-rails and don't install in prod image #2478

Replace sass-rails with sassc-rails and don't install in prod image #2478

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Replace sass-rails with sassc-rails and don't install in prod image #2478

Replace sass-rails with sassc-rails and don't install in prod image #2478

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants