Update backfill required_rubygems_version task to required_ruby_version #2474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started storing required_ruby_version since 20 March, 2014. At the time it was only used in UI and considered not as important to backfill. rubygems pre installation checks uses gemspec to verify ruby requirements, and bundle install fails when it tries to install a version with incompatible requirements. Now that bundler uses required_ruby_version in dependency resolution it would be nicer if older versions reported their required ruby version on the compact index endpoint. 440314 versions match the `where` criteria.
Closed
1 task
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started storing required_ruby_version since 20 March, 2014. At
the time it was only used in UI and considered not as important to
backfill.
rubygems pre installation checks uses gemspec to verify ruby requirements,
and bundle install fails when it tries to install a version with
incompatible requirements.
Now that bundler uses required_ruby_version in dependency resolution
it would be nicer if older versions reported their required ruby
version on the compact index endpoint.
440314 versions match the
wherecriteria.Related: ruby/rubygems#3870