Fix JSON.dump overload combination #558

tompng · 2023-12-04T10:35:13Z

Fixed this overload

# wrong argument type Hash (expected Integer)
dump({}, io, strict: true)
dump({}, limit, strict: true)

And fixed this NoMethodError

# Works and tested in test code
dump({}, strict: true) # => "{}"
# NoMethodError. was not tested in test code
JSON.dump({}, strict: true) # => undefined method `merge_dump_options' for JSON:Module

tompng · 2023-12-04T10:39:00Z

lib/json/common.rb

@@ -642,12 +639,14 @@ def self.iconv(to, from, string)
    string.encode(to, from)
  end

-  private


merge_dump_options should be private instance method and also private module function

module_function def a_private_instance_method_and_public_module_function end private # module_function rule is cleared def a_private_instance_method # not a module function end

tompng · 2023-12-04T10:44:56Z

lib/json/common.rb

+    if anIO.respond_to?(:to_io)
+      anIO = anIO.to_io
+    elsif limit.nil? && !anIO.respond_to?(:write)
+      anIO, limit = nil, anIO


Fixed the inconsistency

dump(obj, io, nil) #=> io.to_io was called dump(obj, io, 10) #=> io.to_io was not called

And if to_io is called, the result of to_io should be an IO, no need to check for respond_to?(:write)

Fix JSON.dump overload combination

41c2712

tompng commented Dec 4, 2023

View reviewed changes

hsbt mentioned this pull request Dec 4, 2023

Wrong number of arguments for dump in 2.7.0 #555

Closed

hsbt merged commit f11c570 into ruby:master Dec 5, 2023
60 checks passed

tompng deleted the json_dump_args branch December 5, 2023 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix JSON.dump overload combination #558

Fix JSON.dump overload combination #558

Fix JSON.dump overload combination #558

Fix JSON.dump overload combination #558

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment