Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: argument order #6

Open
gagolews opened this issue Apr 23, 2016 · 2 comments
Open

Question: argument order #6

gagolews opened this issue Apr 23, 2016 · 2 comments

Comments

@gagolews
Copy link

For example: re2_match(pattern, string)

for some the reverse arg order is more natural (string, pattern) (see e.g., stringr functions)

(string, pattern) works better with magrittr's pipe operator to

string %>% re2_match(pattern)

what do you think?
@dselivanov
Copy link

+1

qinwf pushed a commit that referenced this issue Apr 23, 2016
Change: arguments order #6
1a9f78b 
Input is the first one, and pattern is the second one.
@qinwf
Copy link
Owner
qinwf commented Apr 23, 2016

Changes are landed.

@qinwf qinwf mentioned this issue May 18, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gagolews @dselivanov @qinwf