Periodically check for and handle pending GTK events while performing long operations. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… long operations.
|
Any opinion on this? Maybe this particular pull isn't the correct approach but delaying events for an extended time isn't good and it definitely causes problems when using czkawka on Wayland. |
|
I think that correct approach is to move deleting to different thread/threads. |
|
For now is OK, but solution with moving computation to thread will fix also #456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: I really don't know much about GTK (especially with Rust) so this may or may not be the correct approach.
This change checks for and handles a pending GTK event once every 100 files processed. It may make sense to handle all pending events. The frequency of event checking could obviously be changed quote easily, I don't know what the optimal value is but 100 seemed reasonable.
Closes #624