-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement sorting by portion checked within group #538
Conversation
I'm not sure if I correctly understand what exactly functionality is needed. In issue 422(not 444) user probably wants to manually sort results by path, name, size etc. column inside groups. czkawka/czkawka_gui/src/create_tree_view.rs Line 215 in 51df63b
Looking at source code from this PR I don't know what exactly it do. |
@qarmin The main part of the mechanism is: list.push((num_selected as f64 / current_index as f64, range));
// ...
list.sort_by(|&(portion_a, _), &(portion_b, _)| { portion_a.partial_cmp(&portion_b).unwrap() });
let oldpos: Vec<_> = list.into_iter().flat_map(|(_, range)| range).map(|v| v as u32).collect();
model.reorder(&oldpos[..]);
Groups of results with many checked entries will jump to the top or the bottom. In #444 a user requested a way to go to the next group that has all duplicates selected. The idea is that if such groups jump to the top of the list, the user can easily go through all such groups. I can see that a good explanation may be necessary for users to understand this feature. How about a tooltip containing a description, would that be enough? |
Hmmmm.... Also sort button is quite misleading, because users probably think that this will sort results by name, path etc. |
@qarmin ok, you are right about this feature. I will back down on this feature, also because if you didn't grasp it at a first glance, users won't grasp it intuitively as well. However, it may be useful to repurpose this PR to fix #443 by doing
under the menu introduced in this PR, and adding these plus
so that a user may do both actions (sort + select) and arrive at selected only longer path lengths or shorter path lengths, thus fixing issue #443. For consistency within the sort menu, we may indeed add options to sort results in group by e.g. path, size, like you mentioned earlier:
Is there a need to make a distinction between sorting by filename and by path? Also I would do a jump menu to cover #292 as well, so that there would be two kinds of jumps
Sounds like a plan? |
@qarmin you're the expert. Could you assign me some issues to work on? Also, since we both speak Polish it would be handy to exchange cell phone numbers (I won't post mine in public, but I can send you mine via reddit). This way, we could discuss whatever needs to be done, on the phone. Is that ok? |
I don't have any strict plans what features/bugfixes should be available in next version, but I think that this issues could be resolved:
but of course any other features can be also merged if not broke too much current app workflow |
This branch has conflicts that must be resolved |
We agree that this PR is not the right way forward. Closing. Thanks for the list of needed features. |
How do I hide the button on startup?
Do you think this is a useful feature?
Fixes #444