moving cloner functions to beacon_block.go #14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Jul 29, 2024
Comment on lines
+360
to
+363
| // CopyBlobKZGs copies the provided blob kzgs object. | ||
| func CopyBlobKZGs(b [][]byte) [][]byte { | ||
| return bytesutil.SafeCopy2dBytes(b) | ||
| } |
There was a problem hiding this comment.
This function does not achieve anything. You can call bytesutil.SafeCopy2dBytes directly
rkapka
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
removes cloner functions in favor of .Copy() functions. I've left the cloner tests as is as extra safe measures. this does not solve our TODOs around deep not equals
Which issues(s) does this PR fix?
Fixes #
Other notes for review