feat: allow multiple errors to be reported #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this has multiple false positives. It is better to allow multiple errors to be reported through the use of other methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability for multiple errors to be reported. Resolves #17.
Implementation Details
When an error is encountered when iterating through
Parser<I>, a while loop is used to continue iterating through the tokens until an entry that isn't an error is found. This is explained in the comments as part of the initial commit:A unit test has been added to test and demonstrate this functionality.
Note: No functionality to format parse errors has been implemented in this PR; however, this will be done if needed (perhaps in this PR?).