Fix race in a03526d8eb82 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify packets before adding them to NACK buffer.
WARNING: DATA RACE
Read at 0x00c00056d456 by goroutine 10741:
github.com/pion/interceptor/pkg/nack.(*sendBuffer).get()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/send_buffer.go:95 +0x1e4
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets.func1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:153 +0x70
github.com/pion/rtcp.(*NackPair).Range()
/home/runner/go/pkg/mod/github.com/pion/rtcp@v1.2.14/transport_layer_nack.go:65 +0x43
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:152 +0x124
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindRTCPReader.func1.gowrap1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:100 +0x44
Previous write at 0x00c00056d456 by goroutine 10735:
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets.func1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:186 +0x684
github.com/pion/rtcp.(*NackPair).Range()
/home/runner/go/pkg/mod/github.com/pion/rtcp@v1.2.14/transport_layer_nack.go:65 +0x43
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:152 +0x124
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindRTCPReader.func1.gowrap1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:100 +0x44
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 72.93% 73.03% +0.10%
==========================================
Files 79 79
Lines 3687 3679 -8
==========================================
- Hits 2689 2687 -2
+ Misses 865 862 -3
+ Partials 133 130 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify packets before adding them to NACK buffer.
WARNING: DATA RACE
Read at 0x00c00056d456 by goroutine 10741:
github.com/pion/interceptor/pkg/nack.(*sendBuffer).get()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/send_buffer.go:95 +0x1e4
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets.func1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:153 +0x70
github.com/pion/rtcp.(*NackPair).Range()
/home/runner/go/pkg/mod/github.com/pion/rtcp@v1.2.14/transport_layer_nack.go:65 +0x43
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:152 +0x124
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindRTCPReader.func1.gowrap1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:100 +0x44
Previous write at 0x00c00056d456 by goroutine 10735:
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets.func1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:186 +0x684
github.com/pion/rtcp.(*NackPair).Range()
/home/runner/go/pkg/mod/github.com/pion/rtcp@v1.2.14/transport_layer_nack.go:65 +0x43
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:152 +0x124
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindRTCPReader.func1.gowrap1()
/home/runner/go/pkg/mod/github.com/pion/interceptor@v0.1.35/pkg/nack/responder_interceptor.go:100 +0x44
Description
Reference issue
Fixes #...