Fix #448

pdfcpu · Apr 21, 2023 · 73c50d3 · 73c50d3
1 parent e560c3e
commit 73c50d3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/pkg/api/bookmark.go b/pkg/api/bookmark.go
@@ -30,6 +30,8 @@ import (
 // AddBookmarks adds a single bookmark outline layer to the PDF context read from rs and writes the result to w.
 func AddBookmarks(rs io.ReadSeeker, w io.Writer, bms []pdf.Bookmark, conf *model.Configuration) error {
 
+	// Note: Existing bookmarks will be replaced.
+
 	if conf == nil {
 		conf = model.NewDefaultConfiguration()
 	} else {
@@ -69,6 +71,9 @@ func AddBookmarks(rs io.ReadSeeker, w io.Writer, bms []pdf.Bookmark, conf *model
 
 // AddBookmarksFile adds a single bookmark outline layer to the PDF context read from inFile and writes the result to outFile.
 func AddBookmarksFile(inFile, outFile string, bms []pdf.Bookmark, conf *model.Configuration) (err error) {
+
+	// Note: Existing bookmarks will be replaced.
+
 	var f1, f2 *os.File
 
 	if f1, err = os.Open(inFile); err != nil {

diff --git a/pkg/api/test/bookmark_test.go b/pkg/api/test/bookmark_test.go
@@ -29,6 +29,7 @@ import (
 // Mac Preview limitations: does not render color, style, outline tree collapsed by default.
 
 func TestAddSimpleBookmarks(t *testing.T) {
+	// Note: Existing bookmarks will be overwritten.
 	msg := "TestAddSimpleBookmarks"
 	inFile := filepath.Join(inDir, "CenterOfWhy.pdf")
 	outFile := filepath.Join("..", "..", "samples", "bookmarks", "bookmarkSimple.pdf")

diff --git a/pkg/pdfcpu/bookmark.go b/pkg/pdfcpu/bookmark.go
@@ -311,15 +311,13 @@ func createOutlineItemDict(ctx *model.Context, bms []Bookmark, parent *types.Ind
 // AddBookmarks adds bms to ctx.
 func AddBookmarks(ctx *model.Context, bms []Bookmark) error {
 
+	// Note: Existing bookmarks will be replaced.
+
 	rootDict, err := ctx.Catalog()
 	if err != nil {
 		return err
 	}
 
-	if _, ok := rootDict.Find("Outlines"); ok {
-		return errExistingBookmarks
-	}
-
 	outlinesDict := types.Dict(map[string]types.Object{"Type": types.Name("Outlines")})
 	outlinesir, err := ctx.IndRefForNewObject(outlinesDict)
 	if err != nil {