-
Notifications
You must be signed in to change notification settings - Fork 413
[Feature] Add support for trackio
#3196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation<
8000
/h2>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3196
- 📄 Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
❗ 1 Active SEVs
There are 1 currently active SEVs. If your PR is affected, please view them below:
❌ 7 New Failures, 1 Cancelled Job, 11 Unrelated Failures
As of commit d892fe3 with merge base a7707ca (
):
NEW FAILURES - The following jobs have failed:
- Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
Process completed with exit code 2.
- Continuous Benchmark / GPU Pytest benchmark (gh)
Process completed with exit code 2.
- Generate documentation / build-docs (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 399af08a6ba09cc827cb315fca7053d3dd1010300946b868043bede5a8e4b5fd /exec failed with exit code 2
- Habitat Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t a78f3f5357a9ab50c774dc7ab3c8ca5cded71468ca214dd55b94c165d8fafa39 /exec failed with exit code 1
- Libs Tests on Linux / unittests-gym (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 0fc2ee0774ac1574fd8c15ed058c8ff58d5b5d2aaf08787e5cbe0835fb85ccf2 /exec failed with exit code 1
- Libs Tests on Linux / unittests-sklearn (3.10, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 8ad0e2548448a65e6c2e651f9ba361f1286c62188513feaa96a4f5f0f9987565 /exec failed with exit code 2
- SOTA Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t dd53d998c1cbd2fd7138424dd1c210977706ed22d19524597d6cde1122efe319 /exec failed with exit code 1
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
- Unit-tests on Linux / tests-cpu (3.10) / linux-job (gh) (similar failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
- Unit-tests on Linux / tests-cpu (3.9) / linux-job (gh) (similar failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
BROKEN TRUNK - The following jobs failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
- Continuous Benchmark / CPU Pytest benchmark (gh) (trunk failure)
Process completed with exit code 2.
- LLM Tests on Linux / unittests (3.9, 12.8) / linux-job (gh) (trunk failure)
##[error]The operation was canceled.
- Unit-tests on Linux / tests-cpu (3.11) / linux-job (gh) (trunk failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
- Unit-tests on Linux / tests-cpu (3.12) / linux-job (gh) (trunk failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
- Unit-tests on Linux / tests-gpu (3.11, 12.8) / linux-job (gh) (trunk failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
- Unit-tests on Linux / tests-olddeps (3.9, 11.6) / linux-job (gh) (trunk failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
- Unit-tests on Linux / tests-optdeps (3.11, 12.8) / linux-job (gh) (trunk failure)
test/test_weightsync.py::TestMultiModelUpdates::test_multi_model_tensordict_updates
- Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh) (trunk failure)
test/test_weightsync.py::TestMultiModelUpdates::test_mul
8000
ti_model_tensordict_updates
- Unit-tests on Windows / unittests-cpu (3.10, windows.4xlarge, cpu) / windows-job (gh) (trunk failure)
Process completed with exit code 2.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
meta-cla
bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 14, 2025
vmoens
reviewed
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up!
- We need to add it to the doc (docs/source/reference)
- We need to consider if trackio should be installed as part of the dependencies of the main linux tests
Other than that happy to go ahead
Added the docs and trackio
to the tests deps to try the CI. Let me know if I need to change anything else.
vmoens
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool happy with these changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3196
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 7 New Failures, 1 Cancelled Job, 11 Unrelated FailuresAs of commit d892fe3 with merge base a7707ca ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up!
- We need to add it to the doc (docs/source/reference)
- We need to consider if trackio should be installed as part of the dependencies of the main linux tests
Other than that happy to go ahead
Added the docs and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool happy with these changes!
Description
Add support for
trackio
, for now I have a small trouble with the video save folder (cf gradio-app/trackio#307), but the logging works.Edit: gradio-app/trackio#307 was solved.
Motivation and Context
Fix #3195
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!