Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crow_/col_indices to view types #63176

Closed
wants to merge 1 commit into from
Closed

Conversation

cpuhrsch
Copy link
Contributor
@cpuhrsch cpuhrsch commented Aug 12, 2021

Fixes #61103

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Aug 12, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 69fdf29 (more details on the Dr. CI page):


  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-scanned failure(s)

2 failures not recognized by patterns:

Job Step Action
GitHub Actions Lint / shellcheck Assert that regenerating the workflows didn't change them 🔁 rerun
GitHub Actions Lint / quick-checks Ensure GitHub PyPi dependencies are pinned 🔁 rerun

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpuhrsch cpuhrsch requested a review from albanD August 13, 2021 22:24
@cpuhrsch cpuhrsch marked this pull request as ready for review August 13, 2021 22:24
@cpuhrsch cpuhrsch requested a review from soulitzer as a code owner August 13, 2021 22:24
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30315882

Summary:
Fixes pytorch#61103

Pull Request resolved: pytorch#63176

Reviewed By: malfet, albanD

Differential Revision: D30315882

Pulled By: cpuhrsch

fbshipit-source-id: 7ade85f56181d6b1d152c3ba42e9ae5a96a4fc83
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30315882

@codecov
Copy link
codecov bot commented Sep 8, 2021

Codecov Report

Merging #63176 (69fdf29) into master (c1b701b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #63176      +/-   ##
==========================================
- Coverage   66.72%   66.72%   -0.01%     
==========================================
  Files         709      709              
  Lines       92363    92363              
==========================================
- Hits        61628    61625       -3     
- Misses      30735    30738       +3     

@facebook-github-bot
Copy link
Contributor

@cpuhrsch merged this pull request in b7adb33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug builds break sparse CSR
4 participants