[DDP Communication Hook] Simplify the implementation of parseHookResult of PythonCommHook #62389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt of PythonCommHook Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit cb923fe (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
wayi1
pushed a commit
that referenced
this pull request
Jul 29, 2021
…lt of PythonCommHook Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) ghstack-source-id: 134599912 Pull Request resolved: #62389
…rseHookResult of PythonCommHook" Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
…rseHookResult of PythonCommHook" Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
…rseHookResult of PythonCommHook" Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
…rseHookResult of PythonCommHook" Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
…rseHookResult of PythonCommHook" Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Jul 29, 2021
…lt of PythonCommHook Pull Request resolved: #62389 Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. ghstack-source-id: 134603664 Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/)
…rseHookResult of PythonCommHook" Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Jul 29, 2021
…lt of PythonCommHook Pull Request resolved: #62389 Simplify the implementation of `parseHookResult` of `PythonCommHook`, by not directly accepting the output of allreduce, which is a tensor list. Address the comment on #62074 (comment) Additionally, formatter is also applied to `OptimizerHookState` and `hook_then_optimizer`. ghstack-source-id: 134626246 Differential Revision: [D29982485](https://our.internmc.facebook.com/intern/diff/D29982485/)
rohan-varma
approved these changes
Jul 29, 2021
Good point! Will do in the next PR. |
|
This pull request has been merged in acba9b3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Simplify the implementation of
parseHookResultofPythonCommHook, by not directly accepting the output of allreduce, which is a tensor list.Address the comment on #62074 (comment)
Additionally, formatter is also applied to
OptimizerHookStateandhook_then_optimizer.Differential Revision: D29982485