Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Adds no batch dim support for AdativeMaxPool*D #61847

Closed
wants to merge 5 commits into from
Closed

ENH Adds no batch dim support for AdativeMaxPool*D #61847

wants to merge 5 commits into from

Conversation

thomasjpfan
Copy link
Contributor

Towards #60585

@thomasjpfan thomasjpfan added the module: nn Related to torch.nn label Jul 19, 2021
@thomasjpfan thomasjpfan requested a review from jbschlosser July 19, 2021 14:50
@thomasjpfan thomasjpfan requested a review from albanD as a code owner July 19, 2021 14:50
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jul 19, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit bb32a9e (more details on the Dr. CI page and at hud.pytorch.org/pr/61847):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@thomasjpfan thomasjpfan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 19, 2021
@albanD albanD removed their request for review July 19, 2021 16:56
jbschlosser
jbschlosser reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Implementation + testing is solid - just a couple minor doc comments below

test/test_nn.py Outdated Show resolved Hide resolved
torch/nn/modules/pooling.py Outdated Show resolved Hide resolved
torch/nn/modules/pooling.py Show resolved Hide resolved
jbschlosser
jbschlosser approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in 89ca638.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
cla signed Merged module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @facebook-github-bot @jbschlosser @pytorchbot