Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Ubuntu version checks #61738

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary Ubuntu version checks #61738

wants to merge 1 commit into from

Conversation

xuhdev
Copy link
Collaborator
@xuhdev xuhdev commented Jul 15, 2021

PR #5401 missed another Ubuntu version check in cmake/MiscCheck.cmake.

The check for available functions added by #5401 are already present below the code snippet that this PR deletes.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jul 15, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 14790ca (more details on the Dr. CI page and at hud.pytorch.org/pr/61738):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jul 16 23:10:54 sccache: error: deadline has elapsed 
Jul 16 23:10:54 make[1]: *** [third_party/fbgemm/CMakeFiles/fbgemm_avx2.dir/all] Error 2
Jul 16 23:10:54 make: *** [all] Error 2
Jul 16 23:10:54 Makefile:138: recipe for target 'all' failed
Jul 16 23:10:54 -- Building version 1.10.0a0+git14790ca
Jul 16 23:10:54 cmake -DBUILD_ENVIRONMENT=pytorch-linux-xenial-py3-clang5-asan-build -DBUILD_PYTHON=True -DBUILD_TEST=True -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/var/lib/jenkins/workspace/torch -DCMAKE_PREFIX_PATH=/opt/conda/lib/python3.6/site-packages -DNUMPY_INCLUDE_DIR=/opt/conda/lib/python3.6/site-packages/numpy/core/include -DOPENSSL_ROOT_DIR=/opt/openssl -DPYTHON_EXECUTABLE=/opt/conda/bin/python -DPYTHON_INCLUDE_DIR=/opt/conda/include/python3.6m -DPYTHON_LIBRARY=/opt/conda/lib/libpython3.6m.so.1.0 -DTORCH_BUILD_VERSION=1.10.0a0+git14790ca -DUSE_ASAN=1 -DUSE_CUDA=0 -DUSE_MKLDNN=0 -DUSE_NUMPY=True /var/lib/jenkins/workspace
Jul 16 23:10:54 cmake --build . --target install --config Release -- -j 3
Jul 16 23:10:54 + cleanup
Jul 16 23:10:54 + retcode=1
Jul 16 23:10:54 + set +x
Jul 16 23:10:54 =================== sccache compilation log ===================
Jul 16 23:10:54 sccache: error: deadline has elapsed
Jul 16 23:10:54 
Jul 16 23:10:54 =========== If your build fails, please take a look at the log above for possible reasons ===========
Jul 16 23:10:54 Compile requests                      0
Jul 16 23:10:54 Compile requests executed             0
Jul 16 23:10:54 Cache hits                            0
Jul 16 23:10:54 Cache misses                          0
Jul 16 23:10:54 Cache timeouts                        0
Jul 16 23:10:54 Cache read errors                     0
Jul 16 23:10:54 Forced recaches                       0
Jul 16 23:10:54 Cache write errors                    0

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@xuhdev xuhdev requested review from malfet and ezyang July 15, 2021 23:38
@anjali411 anjali411 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 16, 2021
@xuhdev
Remove unnecessary Ubuntu version checks
14790ca 
PR pytorch#5401 missed another Ubuntu version check in `cmake/MiscCheck.cmake`.

The check for available functions added by pytorch#5401 are already present below the code snippet that this PR deletes.
@xuhdev xuhdev force-pushed the remove-redundancy branch from bd02465 to 14790ca Compare July 16, 2021 22:34
ezyang
ezyang approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor
@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i luv me some dead code removal

@facebook-github-bot
Copy link
Contributor

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in f912889.

@xuhdev xuhdev deleted the remove-redundancy branch July 19, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xuhdev @facebook-github-bot @ezyang @anjali411 @pytorchbot