Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchNorm2D #61012

Closed
wants to merge 15 commits into from
Closed

BatchNorm2D #61012

wants to merge 15 commits into from

Conversation

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 30, 2021

💊 CI failures summary and remediations

As of commit ed4443b (more details on the Dr. CI page and at hud.pytorch.org/pr/61012):


  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-scanned failure(s)

2 failures not recognized by patterns:

Job Step Action
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / test (default, 2, 2, windows.4xlarge) Install Visual Studio 2019 toolchain 🔁 rerun
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / test (default, 1, 2, windows.4xlarge) Install Visual Studio 2019 toolchain 🔁 rerun

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

migeed-z added a commit that referenced this pull request Jun 30, 2021
ghstack-source-id: e3d6912683ab187680da55837adc807045f4431b
Pull Request resolved: #61012
[ghstack-poisoned]
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 30, 2021
ghstack-source-id: cfd293baf54be3734c3d12e94af881a6e2b3a304
Pull Request resolved: #61012
@migeed-z migeed-z changed the title ResNet50 BatchNorm2D Jun 30, 2021
[ghstack-poisoned]
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jul 1, 2021
ghstack-source-id: 6b781a75e521e3a3acde86c0ef74c5e2d1722fc7
Pull Request resolved: #61012
@migeed-z migeed-z mentioned this pull request Jul 1, 2021
migeed-z added 6 commits June 30, 2021 19:58
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@migeed-z
Copy link
Contributor Author
migeed-z commented Jul 6, 2021

@migeed-z has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Collaborator
@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

if n.op == 'call_module':
op_type = getattr(self.traced, str(n.target))
if type(op_type) in _INFERENCE_RULES:
return _INFERENCE_RULES[type(op_type)](n, op_type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document somewhere what the schema for inference rules should be since now it's not just the Node. For example, without reading this code, I don't know what the op_type argument is supposed to be. It seems like it's actually the module instance rather than the type?

Copy link
Contributor Author
@migeed-z migeed-z Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's the module in this case. I'll rename it and add documentation.

torch/fx/experimental/graph_gradual_typechecker.py Outdated Show resolved Hide resolved
migeed-z added 3 commits July 6, 2021 18:48
Differential Revision: [D29562337](https://our.internmc.facebook.com/intern/diff/D29562337)

[ghstack-poisoned]
Differential Revision: [D29562337](https://our.internmc.facebook.com/intern/diff/D29562337)

[ghstack-poisoned]
Differential Revision: [D29562337](https://our.internmc.facebook.com/intern/diff/D29562337)

[ghstack-poisoned]
Copy link
Collaborator
@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Differential Revision: [D29562337](https://our.internmc.facebook.com/intern/diff/D29562337)

[ghstack-poisoned]
@migeed-z
Copy link
Contributor Author
migeed-z commented Jul 7, 2021

@migeed-z has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@migeed-z merged this pull request in 39a76fe.

@facebook-github-bot facebook-github-bot deleted the gh/migeed-z/12/head branch July 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants