Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Averaging] Provide a util function for model averaging #60303

Closed
wants to merge 6 commits into from

Conversation

wayi1
Copy link
Contributor
@wayi1 wayi1 commented Jun 18, 2021

Stack from ghstack:

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Proposal: #59699

Differential Revision: D29242806

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 18, 2021

💊 CI failures summary and remediations

As of commit cd89a27 (more details on the Dr. CI page and at hud.pytorch.org/pr/60303):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_xla_linux_bionic_py3_6_clang9_test Run tests 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue cla signed labels Jun 18, 2021
wayi1 pushed a commit that referenced this pull request Jun 18, 2021
The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

ghstack-source-id: 131874673
Pull Request resolved: #60303
@wayi1 wayi1 requested a review from rohan-varma June 19, 2021 05:32
…ing"

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Jun 19, 2021
Pull Request resolved: #60303

The util function can be used for averaging parameters.

More optimizations can be done in the future.
ghstack-source-id: 131897728

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)
…ing"

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

[ghstack-poisoned]
…ing"

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Jun 19, 2021
Pull Request resolved: #60303

The util function can be used for averaging parameters.

More optimizations can be done in the future.
ghstack-source-id: 131899104

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)
Copy link
Member
@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one concern about non-world subgroups.

@wayi1 wayi1 requested a review from rohan-varma June 19, 2021 23:46
…ing"

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Jun 19, 2021
Pull Request resolved: #60303

The util function can be used for averaging parameters.

More optimizations can be done in the future.
ghstack-source-id: 131907564

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)
@rohan-varma rohan-varma self-requested a review June 23, 2021 19:50
…ing"

The util function can be used for averaging parameters.

More optimizations can be done in the future.

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Jun 23, 2021
Pull Request resolved: #60303

The util function can be used for averaging parameters.

More optimizations can be done in the future.
ghstack-source-id: 132214212

Differential Revision: [D29242806](https://our.internmc.facebook.com/intern/diff/D29242806/)
Copy link
Member
@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in aeea5bf.

@facebook-github-bot facebook-github-bot deleted the gh/SciPioneer/130/head branch June 27, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants