Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure num_threads is initialized before calling omp_get_max_threads #60185

Closed
wants to merge 8 commits into from
Closed

Ensure num_threads is initialized before calling omp_get_max_threads #60185

wants to merge 8 commits into from

Conversation

peterbell10
Copy link
Collaborator
@peterbell10 peterbell10 commented Jun 17, 2021 •
edited by ngimel
Loading

Stack from ghstack:

get_num_threads is usually called before parallel_for so there's no
guaruntee we've initialized num_threads properly.

Differential Revision: D29287814

@peterbell10
Ensure num_threads is initialized before calling omp_get_max_threads
381b510 
`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
This was referenced Jun 17, 2021
Closed
Closed
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 17, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 38d45ca (more details on the Dr. CI page and at hud.pytorch.org/pr/60185):

  • 2/3 failures introduced in this PR
  • 1/3 broken upstream at merge base f658fff on Jun 17 from 8:18am to 10:30am

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/scripts/windows_cuda_install.sh
Auto-merging .circleci/scripts/windows_cuda_install.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/setup_ci_environment.sh
Auto-merging .circleci/scripts/setup_ci_environment.sh
CONFLICT (add/add): Merge conflict in .circleci/docker/build.sh
Auto-merging .circleci/docker/build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/scripts/windows_cuda_install.sh
Auto-merging .circleci/scripts/windows_cuda_install.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/setup_ci_environment.sh
Auto-merging .circleci/scripts/setup_ci_environment.sh
CONFLICT (add/add): Merge conflict in .circleci/docker/build.sh
Auto-merging .circleci/docker/build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

peterbell10 added a commit that referenced this pull request Jun 17, 2021
@peterbell10
Ensure num_threads is initialized before calling omp_get_max_threads
0b2558f 
`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

ghstack-source-id: d2e165b075ce8a8d57aa01c7f6aec2d85448e6a1
Pull Request resolved: #60185
@peterbell10 peterbell10 added module: openmp Related to OpenMP (omp) support in PyTorch open source labels Jun 17, 2021
@peterbell10 peterbell10 requested a review from ngimel June 17, 2021 16:27
@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
eb1e304 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
8a924b4 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
980f367 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
462ad01 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
b44f5a6 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
ad81394 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Jun 17, 2021
@peterbell10
Ensure num_threads is initialized before calling omp_get_max_threads
6c94c55 
`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

ghstack-source-id: fe8c5fc57df8f568fdcf89c7295ee5a45bb0e997
Pull Request resolved: #60185
@ngimel
Copy link
Collaborator
ngimel commented Jun 22, 2021

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@peterbell10
Update on "Ensure num_threads is initialized before calling omp_get_m…
38d45ca 
…ax_threads"

`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

Differential Revision: [D29287814](https://our.internmc.facebook.com/intern/diff/D29287814)

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Jun 22, 2021
@peterbell10
Ensure num_threads is initialized before calling omp_get_max_threads
ce6f2e5 
`get_num_threads` is usually called before `parallel_for` so there's no
guaruntee we've initialized `num_threads` properly.

ghstack-source-id: fb0c6c96b67673f05b7fe7a06850acc43a6b2a8a
Pull Request resolved: #60185
@ngimel
Copy link
Collaborator
ngimel commented Jun 22, 2021

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 66452e0.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/78/head branch June 26, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
cla signed Merged module: openmp Related to OpenMP (omp) support in PyTorch open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbell10 @facebook-github-bot @ngimel