Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parametrization to be nested #65167

Closed
wants to merge 1 commit into from

Conversation

albanD
Copy link
Collaborator
@albanD albanD commented Sep 16, 2021

Fixes #65163

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Sep 16, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit eb68502 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link
codecov bot commented Sep 16, 2021

Codecov Report

Merging #65167 (eb68502) into master (8800a8b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #65167      +/-   ##
==========================================
- Coverage   66.37%   66.31%   -0.07%     
==========================================
  Files         727      732       +5     
  Lines       93571    93781     +210     
==========================================
+ Hits        62109    62189      +80     
- Misses      31462    31592     +130     

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in d37c02b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametrization cannot be parametrized
3 participants