Make unary tests runnable if SCIPY is not installed #59304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding `if TEST_SCIPY else _NOTHING` to special.i1 and special.i1e
💊 CI failures summary and remediationsAs of commit 53ca01d (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks!! |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: By adding `if TEST_SCIPY else _NOTHING` to special.i1 and special.i1e Discovered while running tests on M1 Pull Request resolved: pytorch#59304 Reviewed By: jbschlosser Differential Revision: D28835693 Pulled By: malfet fbshipit-source-id: e4fde6584da29fa43bc6da75eebe560512754ed0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding
if TEST_SCIPY else _NOTHINGto special.i1 and special.i1eDiscovered while running tests on M1