Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved JIT support for torch.einsum #59265

Closed
wants to merge 7 commits into from
Closed

Improved JIT support for torch.einsum #59265

wants to merge 7 commits into from

Conversation

heitorschueroff
Copy link
Contributor
@heitorschueroff heitorschueroff commented Jun 1, 2021 •
edited
Loading

Added JIT support for the vararg version of torch.einsum. Note that JIT does not support the Python's Ellipsis object (...)

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Jun 1, 2021
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 1, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 7fff843 (more details on the Dr. CI page and at hud.pytorch.org/pr/59265):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Lint / mypy (1/1)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-06-22T15:51:55.7376312Z torch/utils/benchm...ction "median" in typed context [no-untyped-call] 
2021-06-22T15:51:38.7116750Z env:
2021-06-22T15:51:38.7117351Z   pythonLocation: /opt/hostedtoolcache/Python/3.8.10/x64
2021-06-22T15:51:38.7118271Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.10/x64/lib
2021-06-22T15:51:38.7118846Z ##[endgroup]
2021-06-22T15:51:38.7300787Z + for CONFIG in mypy*.ini
2021-06-22T15:51:38.7302881Z + mypy --config=mypy-strict.ini
2021-06-22T15:51:53.1599589Z torch/utils/benchmark/utils/common.py:166:34: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-22T15:51:53.1602280Z torch/utils/benchmark/utils/common.py:168:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-22T15:51:53.1604435Z torch/utils/benchmark/utils/common.py:169:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-22T15:51:53.1606869Z torch/utils/benchmark/utils/common.py:281:18: error: Call to untyped function "round" in typed context  [no-untyped-call]
2021-06-22T15:51:55.7376312Z torch/utils/benchmark/utils/timer.py:304:24: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-22T15:52:01.0566522Z Found 5 errors in 2 files (checked 141 source files)
2021-06-22T15:52:02.0400281Z ##[error]Process completed with exit code 1.
2021-06-22T15:52:02.0503327Z Post job cleanup.
2021-06-22T15:52:02.1619633Z [command]/usr/bin/git version
2021-06-22T15:52:02.1682728Z git version 2.32.0
2021-06-22T15:52:02.1732170Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-06-22T15:52:02.1777459Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-06-22T15:52:02.2065543Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-06-22T15:52:02.2105599Z http.https://github.com/.extraheader
2021-06-22T15:52:02.2115160Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@heitorschueroff heitorschueroff requested a review from mruberry June 1, 2021 21:48
@heitorschueroff heitorschueroff force-pushed the heitorschueroff/einsum/jit branch from bafdb5c to d6b8a7b Compare June 1, 2021 21:51
@heitorschueroff heitorschueroff mentioned this pull request Jun 3, 2021
Open
@mruberry
Copy link
Collaborator
mruberry commented Jun 9, 2021

This is a really cool extension of einsum jit support. @Krovatkin, is there someone familiar with the jit's varargs handling who can take a look from the jit side?

@heitorschueroff
Copy link
Contributor Author

@Krovatkin any updates here? @Lilyjjo and @eellison could one of you (or both) take a look at this PR please?

@Lilyjjo
Copy link
Contributor
Lilyjjo commented Jun 18, 2021

Hi, I'm really not familiar with the varargs -- if @eellison isn't either I can help find someone on the JIT team who is!

Krovatkin
Krovatkin reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor
@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall! I have a quick question above.

test/test_jit.py Outdated Show resolved Hide resolved
Krovatkin
Krovatkin approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor
@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Looks gut to me on the JIT side @mruberry

@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 8f658d5.

@heitorschueroff heitorschueroff deleted the heitorschueroff/einsum/jit branch July 14, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry left review comments

@Krovatkin Krovatkin Krovatkin approved these changes

Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heitorschueroff @facebook-github-bot @mruberry @Lilyjjo @Krovatkin