Add aten::softmax NNAPI converter #58539

axitkhurana · 2021-05-19T06:34:55Z

Stack from ghstack:

Summary:

Add support for aten::softmax op in the NNAPI model converter with
flexible size

Test Plan:

pytest test/test_nnapi.py::TestNNAPI::test_softmax

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D28531946

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

facebook-github-bot · 2021-05-19T06:35:01Z

💊 CI failures summary and remediations

As of commit fac0cf4 (more details on the Dr. CI page and at hud.pytorch.org/pr/58539):

1/2 failures possibly* introduced in this PR
- 1/1 non-scanned failure(s)
1/2 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jul 06 18:46:18 unknown file: Failure

Jul 06 18:46:18 frame #7: <unknown function> + 0x8ad185 (0x5595a6e46185 in build/bin/test_api)
Jul 06 18:46:18 frame #8: <unknown function> + 0x8ad435 (0x5595a6e46435 in build/bin/test_api)
Jul 06 18:46:18 frame #9: testing::internal::UnitTestImpl::RunAllTests() + 0xc1c (0x5595a6e4748c in build/bin/test_api)
Jul 06 18:46:18 frame #10: testing::UnitTest::Run() + 0x98 (0x5595a6e47758 in build/bin/test_api)
Jul 06 18:46:18 frame #11: main + 0xc8 (0x5595a67bd328 in build/bin/test_api)
Jul 06 18:46:18 frame #12: __libc_start_main + 0xe7 (0x7fafc1b17bf7 in /lib/x86_64-linux-gnu/libc.so.6)
Jul 06 18:46:18 frame #13: _start + 0x2a (0x5595a67f3a0a in build/bin/test_api)
Jul 06 18:46:18 " thrown in the test body.
Jul 06 18:46:18 [  FAILED  ] IntegrationTest.MNIST_CUDA (4 ms)
Jul 06 18:46:18 [ RUN      ] IntegrationTest.MNISTBatchNorm_CUDA
Jul 06 18:46:18 unknown file: Failure
Jul 06 18:46:18 C++ exception with description "Error opening images file at test/cpp/api/mnist/train-images-idx3-ubyte
Jul 06 18:46:18 Exception raised from read_images at /var/lib/jenkins/workspace/torch/csrc/api/src/data/datasets/mnist.cpp:67 (most recent call first):
Jul 06 18:46:18 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6b (0x7fafc22d8cfb in /var/lib/jenkins/workspace/build/lib/libc10.so)
Jul 06 18:46:18 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xce (0x7fafc22d499e in /var/lib/jenkins/workspace/build/lib/libc10.so)
Jul 06 18:46:18 frame #2: <unknown function> + 0x41e2d02 (0x7fafd60e0d02 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Jul 06 18:46:18 frame #3: torch::data::datasets::MNIST::MNIST(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, torch::data::datasets::MNIST::Mode) + 0x46 (0x7fafd60e1da6 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Jul 06 18:46:18 frame #4: IntegrationTest_MNISTBatchNorm_CUDA_Test::TestBody() + 0x9d6 (0x5595a69be3d6 in build/bin/test_api)
Jul 06 18:46:18 frame #5: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4a (0x5595a6e4f47a in build/bin/test_api)
Jul 06 18:46:18 frame #6: <unknown function> + 0x8acb75 (0x5595a6e45b75 in build/bin/test_api)
Jul 06 18:46:18 frame #7: <unknown function> + 0x8ad185 (0x5595a6e46185 in build/bin/test_api)

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

axitkhurana · 2021-05-19T06:39:30Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-06-03T20:45:49Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-06-29T08:03:58Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

Summary: Add support for aten::softmax op in the NNAPI model converter with flexible size Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_softmax Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-06-29T08:25:07Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

axitkhurana · 2021-06-29T19:02:00Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Add support for aten::softmax op in the NNAPI model converter with flexible size Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_softmax Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-06-29T21:05:27Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Add support for aten::softmax op in the NNAPI model converter with flexible size Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_softmax Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-06-30T06:39:54Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Add support for aten::softmax op in the NNAPI model converter with flexible size Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_softmax Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-06-30T18:39:30Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

dreiss · 2021-06-30T18:54:11Z

torch/backends/_nnapi/serializer.py

+        for dim, size in enumerate(in_oper.shape):
+            if size == 0:
+                self.forward_operand_shape(out_id, dim, in_id, dim)


Do you think this is a common enough pattern to justify making it a helper function?

I think so, I'll add a clean up task

Summary: Add support for aten::softmax op in the NNAPI model converter with flexible size Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_softmax Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana · 2021-07-06T17:43:12Z

@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-07-07T19:41:07Z

This pull request has been merged in 14d604a.

softmax

73ee735

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

facebook-github-bot added the cla signed label May 19, 2021

This was referenced May 19, 2021

Add aten::avgpool2d NNAPI converter #58538

Closed

Add aten::to NNAPI converter #58540

Closed

Add aten::div NNAPI converter #58541

Closed

Add flatten #58542

Closed

Add aten::detach NNAPI converter #58543

Closed

Update on "softmax"

92037d6

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

This was referenced Jun 3, 2021

Add aten::slice NNAPI converter #59364

Closed

Add Int32 support for NNAPI #59365

Closed

This was referenced Jun 4, 2021

NNAPI: Support const values in binary ops #59434

Closed

Add conv2d transpose NNAPI converter #59529

Closed

Update on "softmax"

1d98b0c

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana mentioned this pull request Jun 28, 2021

Add aten::flatten NNAPI converter #60885

Closed

Update on "softmax"

9ec8b6f

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

Akshit Khurana added 2 commits June 29, 2021 01:14

Update on "softmax"

7ebc28e

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28531946](https://our.internmc.facebook.com/intern/diff/D28531946) [ghstack-poisoned]

axitkhurana changed the title ~~softmax~~ Add aten::softmax NNAPI converter Jun 29, 2021

This was referenced Jun 30, 2021

Make conv2d nnapi converter accept flexible batch #61021

Closed

Make NNAPI linear converter accept flex inputs #61022

Closed

Make nnapi cat converter accept flex inputs #61023

Closed

This was referenced Jun 30, 2021

Make nnapi flatten converter accept flex inputs #61024

Closed

Add option to specify custom NNAPI serializer #61025

Closed

dreiss approved these changes Jun 30, 2021

View reviewed changes

Akshit Khurana added 3 commits June 30, 2021 12:30

facebook-github-bot closed this in 14d604a Jul 7, 2021

facebook-github-bot added the Merged label Jul 7, 2021

facebook-github-bot deleted the gh/axitkhurana/7/head branch July 11, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aten::softmax NNAPI converter #58539

Add aten::softmax NNAPI converter #58539

Add aten::softmax NNAPI converter #58539

Add aten::softmax NNAPI converter #58539

Conversation

💊 CI failures summary and remediations

❄️ 1 failure tentatively classified as flaky

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 (1/1)

Choose a reason for hiding this comment

Choose a reason for hiding this comment