[PyTorch] Migrate TensorAdvancedIndexing TI usage to borrowing where possible #58276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible Borrowing is more efficient, and we can see in all these cases that the TensorIterator doesn't outlive the input & output Tensors. Differential Revision: [D28428234](https://our.internmc.facebook.com/intern/diff/D28428234/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 48595ad (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 13, 2021
swolchok
added a commit
that referenced
this pull request
May 13, 2021
…possible Borrowing is more efficient, and we can see in all these cases that the TensorIterator doesn't outlive the input & output Tensors. Differential Revision: [D28428234](https://our.internmc.facebook.com/intern/diff/D28428234/) ghstack-source-id: 128948368 Pull Request resolved: #58276
This was referenced May 13, 2021
…wing where possible" Borrowing is more efficient, and we can see in all these cases that the TensorIterator doesn't outlive the input & output Tensors. Differential Revision: [D28428234](https://our.internmc.facebook.com/intern/diff/D28428234/) [ghstack-poisoned]
This was referenced May 14, 2021
ngimel
approved these changes
May 17, 2021
|
This pull request has been merged in 029289b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Borrowing is more efficient, and we can see in all these cases that the TensorIterator doesn't outlive the input & output Tensors.
Differential Revision: D28428234