Test fixes for changes in recent upstream Python (#581) #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Python upstream recently fixed the behavior of inspect with wrappers: python/cpython#112006 . The assertion here relies on the broken behavior, we only get None if `inspect(Wrapped)` fails and raises `ValueError`. Now it works, we actually get the correct answer, 1. This changes it so we assert the correct thing depending on the Python version (the fix was backported to 3.11.9 and 3.12.3, so the check has to be a bit complicated). Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Thanks for doing this, and for investigating the other test failure cause. |
jrbourbeau
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a couple of fixes for changes in recent Python: 3.13 deindents docstrings, and a fix for inspecting wrappers was landed in 3.13 and backported to 3.12.3 and 3.11.9, which breaks the expectations of the
test_inspect_wrapped_propertytest.Note a couple of tests still fail against current Python 3.13 due to python/cpython#120526 . I did not want to upstream a workaround for that to toolz, since the correct fix is for the
mapsignature to be corrected in Python: python/cpython#120528 fixes that.