Fix Create node does not raise type error #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 7, 2024 14:50
Comparing a tuple and a list does not perform the expected equality test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #784
This fixes the issue by type-checking every newly created node even when it is found in the
formulaemap.No overhead should have been added as the type is cached.
This also fixes the tests where a type error in smtlib was not noticed, and adds new ones.
Minor: This also fixes the decision on retrying building a type-invalid node in the smtlib parser. Namely, if there are no integer constants within the arguments, there is nothing to change and an exception is directly raised.