Fix env usage #700
Fix env usage #700
Conversation
Replace calls to FNode member functions `substitute`, `simplify` and `get_free_variables` with corresponding calls to the `substituter`, `fvo` and `simplifier` objects in the environment.
…ce different from the one at the top of the stack. Remove direct calls to `get_free_variables`, `simplify` and `substitute` of FNode.
Replace calls to `get_free_variables`, `simplify` and `substitute` on FNode with the corresponding calls on the `fvo`, `simplifier`, `substituter` instances in the environment.
Minor change in walker/generic.
|
👋 Is this something that we still want to do? If so, I would probably separate the "cosmetic" breaking change of renaming We can also look into making the rename non-breaking by introducing a secondary keyword argument, but I am not sure this is worth the effort. |
|
I second @marcogario: the aesthetic fix is secondary compared to add the customizability of the environment. I think very few users are using custom environments, so the breaking change should not be too disruptive |
|
At the moment I don't exactly remember the status of this PR. In the next few days I will try to check its status and update it. |
|
It appears there is at least 1 test case failing: yices on macos. I am unable to reproduce the error on my linux machine. Any suggestions? |
I tried to make the naming of
environmentmore uniform: now it should always appear asenv.This breaks backward compatibility since a call like
pippo(environment=my_env)should be modified topippo(env=my_env).In addition, I tried to reduce the number of places where the code ends up calling
get_envto obtain an environment.I am using multiple environments and this behavior was causing some issues.
In some classes and methods I have added an optional
envparameter so that they should work within the given environment if any.I should have "fixed" al the calls to
get_free_variables,simplifyandsubstitute, and most of the calls toget_type.