Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontsubset docs #3500

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fontsubset docs #3500

merged 2 commits into from
Oct 28, 2024

Conversation

cbm755
Copy link
Contributor
@cbm755 cbm755 commented May 17, 2024

The return type is different b/w the new way and the deprecated implementation. Also, verbose only does something for the old code. fontTools is needed only for the deprecated implementation.

src/utils.py Show resolved Hide resolved
@JorjMcKie JorjMcKie self-requested a review May 22, 2024 14:21
@sfadschm
Copy link
sfadschm commented Aug 1, 2024

Should the 'fontTools' requirement then also be removed from the "Optional Features" section of the ReadMe?

@jamie-lemon
Copy link
Collaborator

Should the 'fontTools' requirement then also be removed from the "Optional Features" section of the ReadMe?

No as we are still experimenting with the new functionality.

@jamie-lemon jamie-lemon merged commit ebdb8ba into pymupdf:main Oct 28, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@cbm755 cbm755 deleted the fontsubset_docs branch October 29, 2024 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants