Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't arbitrarily limit set_mark to certain chains #427

Merged
merged 1 commit into from
Dec 16, 2014
Merged

Don't arbitrarily limit set_mark to certain chains #427

merged 1 commit into from
Dec 16, 2014

Conversation

stesie
Copy link
Contributor
@stesie stesie commented Oct 27, 2014

set_mark is currently limited to PREROUTING or OUTPUT chain, i.e. something like the following isn't accepted:

    firewallchain { 'from_mesh:mangle:IPv4':
        ensure  => present,
    }

    firewall { '900 mark mesh to vpn traffic':
        table           => 'mangle',
        chain           => 'from_mesh',
        proto           => 'all',
        jump            => 'MARK',
        set_mark        => '0x2342/0xffffffff',
    }

... however it's perfectly valid wrt. iptables.

@stesie
Don't arbitrarily limit set_mark to certain chains
edcc4ba 
set_mark is not only allowed in PREROUTING or OUTPUT chain,
but also in custom chains, which are called from these.
underscorgan pushed a commit that referenced this pull request Dec 16, 2014
Merge pull request #427 from stesie/fix-set_mark-limit
9c8a2dc 
Don't arbitrarily limit set_mark to certain chains
@underscorgan underscorgan merged commit 9c8a2dc into puppetlabs:master Dec 16, 2014
@underscorgan
Copy link
Contributor

@stesie thanks!

cegeka-jenkins pushed a commit to cegeka/puppet-firewall that referenced this pull request Oct 23, 2017
Merge pull request puppetlabs#427 from stesie/fix-set_mark-limit
cad52bc 
Don't arbitrarily limit set_mark to certain chains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stesie @underscorgan @david22swan