fix play mode replacement, #7688
Conversation
…orarily replace mode to normal.
There was a problem hiding this comment.
I'm almost approved. This is a change in behavior, even if it is a correction, so it should be documented in CHANGES. Other than that, the original issue did mention the tests were missing a check for when loop == false, so maybe adding that test case would be nice. That isn't as important as fixing the behavior, though, and this looks like it does that.
|
|
||
| /** Returns a frame based on the so called state time. This is the amount of seconds an object has spent in the state this | ||
| * Animation instance represents, e.g. running, jumping and so on. The mode specifies whether the animation is looping or not. | ||
| * But if the animation is set to LOOP_PINGPONG and LOOP_RANDOM mode, non-loop param takes no effect. |
There was a problem hiding this comment.
I have some minor comment nitpicks. It should be:
LOOP_PINGPONG or LOOP_RANDOM
and the verb in param takes no effect should be changed to param has no effect .
It's clear enough already that it can be merged now, but if you want to polish it before merging that would be nice.
| } else if (playMode == PlayMode.LOOP) { | ||
| playMode = PlayMode.NORMAL; | ||
| } | ||
| // non-loop param takes no effect on LOOP_PINGPONG and LOOP_RANDOM mode |
There was a problem hiding this comment.
This comment isn't strictly necessary, but I think that if you want this here at all, it should be if the loop param is false, LOOP_PINGPONG and LOOP_RANDOM playModes won't change . Again, a very minor nitpick, especially since users usually won't be reading this.
when looping=false and PlayMode=loop, temporarily replace mode to normal.
#7686