Alternative to #7357 for setting glyph page index. #7388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raeleus
previously approved these changes
Apr 21, 2024
The only "issue" is an unused import, which I guess is technically a code style violation of the most minor variety.
tommyettinger
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
Looks good; cleaner than the approach using a hashCode() and faster than having to go through all Pixmaps that have been packed so far. I'm always in favor of making package-private code public, to boot! Approved.
I did have to run spotlessApply manually for some reason on this PR, since it wasn't building normally. The only problem was a single unused import of Rectangle in FreeTypeFontGenerator. Now it builds and I think it should be mergeable just fine.
crykn
added a commit
that referenced
this pull request
Aug 16, 2024
crykn
added a commit
that referenced
this pull request
Aug 16, 2024
wheelergames
pushed a commit
to wheelergames/libgdx
that referenced
this pull request
Oct 6, 2025
* Alternative to libgdx#7357 for setting glyph page index. * Spotless didn't seem to run initially. The only "issue" is an unused import, which I guess is technically a code style violation of the most minor variety. --------- Co-authored-by: Tommy Ettinger <tommy.ettinger@gmail.com>
wheelergames
pushed a commit
to wheelergames/libgdx
that referenced
this pull request
Oct 6, 2025
See libgdx#7004, libgdx#7096, libgdx#7222, libgdx#7243, libgdx#7254, libgdx#7255, libgdx#7274, libgdx#7278, libgdx#7286, libgdx#7305, libgdx#7306, libgdx#7309, libgdx#7312, libgdx#7350, libgdx#7358, libgdx#7359, libgdx#7362, libgdx#7371, libgdx#7374, libgdx#7378, libgdx#7382, libgdx#7383, libgdx#7388, libgdx#7389, libgdx#7399, libgdx#7410, libgdx#7412, libgdx#7416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I'm late to #7357.
If
packreturned a PixmapPackerRectangle, it could have aPage pagefield. Then we don't need a unique name, don't need to add torectsmap, and page index lookup isindexOfpages rather than checking the name of all rects on all pages.PixmapPackerRectangle is already public and exposed by PixmapPacker.Page#getRects, but all the fields are default access so it's not useful outside the package. All the fields could be public, as I'm guessing that was the intent of exposing the class.