Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attributes with : #39

Closed
zavr-1 opened this issue Oct 12, 2019 · 5 comments
Closed

attributes with : #39

zavr-1 opened this issue Oct 12, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@zavr-1
Copy link
zavr-1 commented Oct 12, 2019

Hey, attributes can have : in attributes, e.g., svgs such as <image xlink:href="example"/>, the regex needs to be updated.
leeoniya added a commit that referenced this issue Oct 12, 2019
@leeoniya
support ":" in attr names. (#39)
2810f87
@leeoniya leeoniya added the bug Something isn't working label Oct 12, 2019
@leeoniya
Copy link
Owner
leeoniya commented Oct 12, 2019 •
edited
Loading

try it out. i couldn't run the tests cause suddenly mocha is barfing at me with MODULE_NOT_FOUND, even with a cleared cache and an emptied /test dir 😕

@zavr-1
Copy link
Author
zavr-1 commented Oct 13, 2019

yeah it worked fine ty

@tornqvist
Copy link

Is there any chance of a new release with this fix in it?

@leeoniya
Copy link
Owner
leeoniya commented Nov 4, 2019

i'll cut one today

@leeoniya
Copy link
Owner
leeoniya commented Nov 4, 2019

1.0.16 is up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leeoniya @tornqvist @zavr-1