src/menu: prevent delayed pipe menu response on item destroy #2094

Consolatis · 2024-08-20T15:04:25Z

Without this patch we would happily access pipe_ctx->item members even if the item had been destroyed in the meantime.

Reproducer:

#!/usr/bin/bash

if test -n "$1"; then
	sleep $1
fi

cat << EOF
<openbox_pipe_menu>
	<menu id="delay-test-$(( RANDOM ))" label="Delay 3" execute="$(readlink -f "$0") 3" />
</openbox_pipe_menu>
EOF

and in menu.xml:

<menu id="root-menu">
  <menu id="delay" label="Delay" execute="~/.config/labwc/pipe_delay.sh" />
</menu>

Open the Delay menu, hover over Delay 3 and then press ESC before the 3 seconds have been elapsed.

Without this patch we would happily access `pipe_ctx->item` members even if the item had been destroyed in the meantime.

johanmalm · 2024-08-20T16:09:06Z

LGTM. Excellent fix. Very much appreciated.

) Without this patch we would happily access `pipe_ctx->item` members even if the item had been destroyed in the meantime.

Without this patch we would happily access `pipe_ctx->item` members even if the item had been destroyed in the meantime.

src/menu: prevent delayed pipe menu response on item destroy

1350738

Without this patch we would happily access `pipe_ctx->item` members even if the item had been destroyed in the meantime.

johanmalm merged commit 5ae9eed into labwc:master Aug 20, 2024
5 of 6 checks passed

Consolatis deleted the fix/menu_destroy_ctx branch August 20, 2024 16:17

johanmalm pushed a commit that referenced this pull request Aug 20, 2024

src/menu: prevent delayed pipe menu response on item destroy (#2094)

7de2a9f

Without this patch we would happily access `pipe_ctx->item` members even if the item had been destroyed in the meantime.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src/menu: prevent delayed pipe menu response on item destroy #2094

src/menu: prevent delayed pipe menu response on item destroy #2094

src/menu: prevent delayed pipe menu response on item destroy #2094

src/menu: prevent delayed pipe menu response on item destroy #2094

Conversation