Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xwayland: set initial geometry in map_request handler #1529

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jlindgren90
Copy link
Contributor

Set the initial geometry of maximized/fullscreen views before actually mapping them, so that they can do their initial layout and drawing with the correct geometry. This avoids visual glitches and also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes:

@jlindgren90 jlindgren90 force-pushed the maximize-before-map branch 2 times, most recently from 0cde989 to 8a60659 Compare February 16, 2024 04:06
@jlindgren90 jlindgren90 changed the title xwayland: set initial geometry in about_to_map handler xwayland: set initial geometry in map_request handler Feb 23, 2024
@jlindgren90
Copy link
Contributor Author

wlroots MR was merged. about_to_map was renamed to map_request.

jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Mar 2, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Mar 4, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Mar 17, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Apr 8, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Apr 8, 2024
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Apr 19, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Apr 19, 2024
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request May 11, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request May 11, 2024
@jlindgren90 jlindgren90 force-pushed the maximize-before-map branch 2 times, most recently from ec5f3c7 to da2eda4 Compare June 30, 2024 18:18
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Jul 2, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

v2: ensure valid geometry for unmanaged->managed case

labwc#1529
jlindgren90 added a commit to jlindgren90/labwc that referenced this pull request Jul 18, 2024
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Depends on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4546

Fixes: labwc#1320

v2: ensure valid geometry for unmanaged->managed case

labwc#1529
Set the initial geometry of maximized/fullscreen views before
actually mapping them, so that they can do their initial layout and
drawing with the correct geometry. This avoids visual glitches and
also avoids undesired layout changes with some apps (e.g. HomeBank).

Fixes: labwc#1320

v2: ensure valid geometry for unmanaged->managed case
@jlindgren90 jlindgren90 marked this pull request as ready for review July 18, 2024 05:06
@jlindgren90
Copy link
Contributor Author

This should be good to go now that we are on wlroots 0.18.

@johanmalm johanmalm merged commit c9018da into labwc:master Jul 19, 2024
3 of 5 checks passed
@johanmalm
Copy link
Collaborator

Thanks

@jlindgren90 jlindgren90 deleted the maximize-before-map branch July 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants