Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top left and top right borders render incorrectly. #988

Closed
burein-ita opened this issue Jul 14, 2023 · 2 comments
Closed

Top left and top right borders render incorrectly. #988

burein-ita opened this issue Jul 14, 2023 · 2 comments
Labels
bug Something isn't working PR pending PR to fix the issue is already pending

Comments

@burein-ita
Copy link

Using 6b83db3
Arch-Linux

Setting cornerRadius to 0 causes the top left and to right borders to render incorrectly.
It is more noticeable if the border thickness is set to some stupid value.

wack

Top picture border is set to 1px.
Bottom one is set to 25px.
@Consolatis Consolatis added bug Something isn't working investigation required Needs further investigation labels Jul 14, 2023
@Consolatis
Copy link
Member
Consolatis commented Jul 14, 2023 •
edited
Loading

Thanks for bringing this up. It also looks very wrong at other cornerRadius values and a 25px border.width. Can be seen best when also changing border.color to #ff0000 or similar.
Something is definitely off here!

johanmalm added a commit to johanmalm/labwc that referenced this issue Jul 15, 2023
@johanmalm
theme: fix rounded-corner bug
5d232f2 
Make top left/right corner pieces with large border thickness pixel
perfect.

Fixes: issue labwc#988
@johanmalm johanmalm mentioned this issue Jul 15, 2023
Merged
@Consolatis Consolatis added PR pending PR to fix the issue is already pending and removed investigation required Needs further investigation labels Jul 17, 2023
johanmalm added a commit to johanmalm/labwc that referenced this issue Jul 17, 2023
@johanmalm
theme: fix rounded-corner bug
bba29f2 
Make top left/right corner pieces with large border thickness pixel
perfect.

Fixes: issue labwc#988
johanmalm added a commit to johanmalm/labwc that referenced this issue Jul 17, 2023
@johanmalm
theme: fix rounded-corner bug
9cf708a 
Make top left/right corner pieces with large border thickness pixel
perfect.

Fixes: issue labwc#988
johanmalm added a commit that referenced this issue Jul 17, 2023
@johanmalm
theme: fix rounded-corner bug
318d881 
Make top left/right corner pieces with large border thickness pixel
perfect.

Fixes: issue #988
@Consolatis
Copy link
Member

Should be fixed by

Thanks again for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working PR pending PR to fix the issue is already pending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Consolatis @burein-ita