Namespace any important strings, such as paths and thread names #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements namespace support for important strings throughout the KSCrash library, specifically for thread names and file paths. The change introduces a new KSCRASH_NS_STRING macro to consistently apply namespace suffixes to string literals used for thread names and directory paths.
- Adds
KSCRASH_NS_STRINGmacro for namespacing string literals - Updates thread name declarations across multiple monitors to use namespaced strings
- Modifies the cache directory path to include namespace support
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| namespacer/namespacer.py | Refactors namespace constants and adds generation of the new KSCRASH_NS_STRING macro |
| Sources/KSCrashCore/include/KSCrashNamespace.h | Defines the new KSCRASH_NS_STRING macro for string namespacing |
| Sources/KSCrashRecording/Monitors/KSCrashMonitor_MachException.c | Updates thread name constants to use the new namespacing macro |
| Sources/KSCrashRecording/Monitors/KSCrashMonitor_Deadlock.m | Updates deadlock monitor thread name to use namespaced string |
| Sources/KSCrashRecording/KSThreadCache.c | Updates thread cache monitor thread name to use namespaced string |
| Sources/KSCrashRecording/KSCrash.m | Updates cache directory path to use namespaced string |
8e93eb5 to
81c580c
Compare
81c580c to
6340528
Compare
kstenerud
commented
Aug 31, 2025
|
|
||
| #endif | ||
|
|
||
| #define KSCRASH_NS_STRING(STR) STR KSCRASH_NAMESPACE_STRING |
There was a problem hiding this comment.
Note that this can't be parenthesized due to how compile-time string concatenation works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is critically important when it comes to the paths, because otherwise both instances of KSCrash will overwrite each other's files.
Before:
{caches-dir}/KSCrash/{bundle-name}After:
{caches-dir}/KSCrash{namespace}/{bundle-name}