Deduplicate lr and the first *(void **)(fp + 8). #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
requested changes
Mar 30, 2025
There was a problem hiding this comment.
The patch looks good overall! There are just a couple of things to address:
-
The code formatting isn't passing the checks. You can either:
- Fix it manually to match the project style, or
- Install clang-format and run
make formatto automatically format it
-
It would be valuable to add an integration test for this case. Take a look at the existing integration tests in the Tests sample folder to see how you might verify this fix in a more real-world scenario.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
Sources/KSCrashRecordingCore/KSStackCursor_MachineContext.c:119
- Although a check is made for a NULL previous frame, consider validating that the pointer returned by kscpu_framePointer() is not NULL before using it in the subsequent conditional to avoid potential null dereference.
context->currentFrame.previous = (struct FrameEntry *)kscpu_framePointer(context->machineContext);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
0 JavaScriptCore JSC::HeapCellType::finishSweep(JSC::MarkedBlock::Handle&, JSC::FreeList*) const()
1 JavaScriptCore JSC::MarkedBlock::Handle::sweep(JSC::FreeList*)()
2 JavaScriptCore JSC::MarkedBlock::Handle::sweep(JSC::FreeList*)()
3 JavaScriptCore JSC::Heap::lastChanceToFinalize()()