Fix catch "Pattern not found"/"Unknown function" when locale is not en #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vim use localized error messages, so current method - catch whole error message - not work when locale is not C/en. This patch replace current user method for E117 and E486 by catch /^Vim\%((\a\+)\)\=:<error number>/
|
Hi! Thank for the useful PR! Looks good and I should've used this instead yes, but it slipped my mind (._.) |
|
v1.3.1 has been released within the master branch with your new fix in it. Thank you for your support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
The plugin does not work when vim locale is not en; i.e. for python files it raises an error on
<C-D>:When calling not-existing functions, vim generates localized errors messages that do not match
catch statements in the plugin.
This patch replaces the current catching method for
E117andE486by one method from:h catch:catch /^Vim\%((\a\+)\)\=:<error number>/