Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g:doge_comment_jump_modes #50

Merged
merged 2 commits into from
Oct 8, 2019
Merged

g:doge_comment_jump_modes #50

merged 2 commits into from
Oct 8, 2019

Conversation

mg979
Copy link
Contributor
@mg979 mg979 commented Oct 6, 2019

Defines the modes in which doge jump mapping should work.
Default: ['n', 'i', 's']

Prelude

Thank you for helping out DoGe!

By contributing to DoGe you agree to the following statements (Replace [ ] with [x] with those you agree with):

Why this PR?

For those that use Tab for autocompletion/snippet expansion, so that it's still possible to use it that way in a doge block. For me normal mode and select mode are enough.

mg979 and others added 2 commits October 6, 2019 21:06
Defines the modes in which doge jump mapping should work.
Default: ['n', 'i', 's']
@kkoomen
Copy link
Owner
kkoomen commented Oct 8, 2019

Thanks for adding this and also adjusting g:mode to s:mode. I made minimum changes to the documentation. Please pay attention next time when adding a new configurable option to:

  • Specifying this option in the README.md
  • Generating the helptags file

If you would've read the contributing guidelines you can see the required checklists for certain pull requests. Here is the section you can read.


This feature will be merged and released in the upcoming version v1.14.0.

Feel free to submit any new issues if you experience any unwanted behavior in the future. Thanks for your contribution.

@kkoomen kkoomen merged commit 7798eec into kkoomen:master Oct 8, 2019
@kkoomen
Copy link
Owner
kkoomen commented Oct 8, 2019

I will look at your other PRs later.

@mg979
Copy link
Contributor Author
mg979 commented Oct 8, 2019

Thanks, but is documenting functions useful for the end user? Maybe they should go in a different doge-implementation.txt doc, that can also contain tips for creating templates (I did mine for vimscript). They feel a bit out of place there, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants