Ensure lazyredraw is enabled (2) #49
Conversation
Enable lazyredraw in doge#activate(), if disabled. Disable in doge#deactivate(), if it has been enabled by DoGe. Disable in test/vimrc because of failing tests.
|
Besides the two comments: happy you came with another solution and I think it's a good option for now. |
|
Do you perhaps know why |
|
Because history is changed when you enter something in the command line ('/'), and you do that in the jump functions (like here), if you set the search register with |
|
It would be maybe better to set the TODO patter directly with |
|
Fair enough. Seems good to me. Anything you like to add? Otherwise I'll merge. I tested it and it works as expected to me. What about you? |
|
I think it's working well, I don't see flashes anymore :). |
|
This bug has been fixed and released in v1.13.1. Feel free to submit any new issues if you experience any unwanted behavior in the future. Thanks for your contribution. |
Prelude
Thank you for helping out DoGe!
By contributing to DoGe you agree to the following statements (Replace
[ ]with[x]with those you agree with):Why this PR?
Similar to #46, but it is controlled by a global variable, that can be set to 0 to disable the check. I don't think it's important to document it because it can only be beneficial, at the same time the test vimrc must be able to disable it.
I'd prefer this approach to the discussed
hlsearchone (that can also work), because ifhlsearchisn't restored it can be annoying.This can happen because right now mappings deactivation is not automatic, it waits for a
Tabthat can't find anything (as it was before, when there weren't buffer mappings).lazyredrawis harmless in comparison and it's pointless not to use it because Vader apparently doesn't support it.The second commit simply restores the old search register after deactivation.