Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup]: remove unused functions and variables #13331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[cleanup]: remove unused functions and variables #13331

wants to merge 3 commits into from

Conversation

iholder101
Copy link
Contributor

What this PR does

Removes unused functions and variables.

/kind cleanup

Release note

NONE

@iholder101
test, network: remove unused function: waitUntilVMIReady()
dc6ec79 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@iholder101
test, storage: remove unused function: newVMWithDataVolumeForExport()
a47ddcc 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@iholder101
virt-api: remove unused variables and constants
d48c0f4 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network sig/storage size/M labels Nov 25, 2024
ShellyKa13
ShellyKa13 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor
@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best kind of PRS!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
EdDev
EdDev approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member
@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the network codebase:

/approve

@ShellyKa13
Copy link
Contributor

then Ill approve the storage codebase:
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EdDev, ShellyKa13
Once this PR has been reviewed and has the lgtm label, please ask for approval from iholder101. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

orelmisan
orelmisan reviewed Nov 25, 2024
View reviewed changes
Copy link
Member
@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @iholder101.
I see usages of the variable / constant that were removed on the last commit.
Could you please have a look?

tests/storage/datavolume.go Show resolved Hide resolved
pkg/virt-api/webhooks/arm64.go Show resolved Hide resolved
pkg/virt-api/webhooks/arm64.go Show resolved Hide resolved
@kubevirt-bot
Copy link
Contributor

@iholder101: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations d48c0f4 link true /test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.31-sig-compute-serial d48c0f4 link true /test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShellyKa13 ShellyKa13 ShellyKa13 approved these changes

@orelmisan orelmisan orelmisan left review comments

@EdDev EdDev EdDev approved these changes

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@EdDev EdDev

@ShellyKa13 ShellyKa13

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network sig/storage size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iholder101 @ShellyKa13 @kubevirt-bot @EdDev @orelmisan