Add "resolv-conf" flag to Kubelet for CoreDNS #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2020 11:53
For systemd-resolvd based systems, core-DNS will fail to start. Using moby/libnetwork, we can detect that, and point kubelet to the real DNS config file. Signed-off-by: Karen Almog <kalmog@mirantis.com>
Signed-off-by: Karen Almog <kalmog@mirantis.com>
jasmingacic
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #390
What this PR Includes
This PR removes the need for "hacking" the
resolv.conffile in systemd-resolvd systems, by finding out the "real" resolv.conf file and passing it as the value for the--resolv-confflag in kubelet.e2e
https://github.com/k0sproject/k0s/actions/runs/361469902 ✅