Always search for the full package name in existing IMPORT-FROMs #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. As opposed to just looking at prefixes. Previously, If you had an existing defpackage like this:
(defpakage :foo
(:import-from :bar/car
:find)))
And you imported bar::position, you'll end up with something ugly like this:
(defpackage :foo
(:import-from :bar
:position/car
:find))
|
This is a pretty common occurrence if you use single-package-per-file style, since packages have a hierarchical structure to them. (PS. My next PR will be a bit more interesting, and you might like it. I have some patches locally where I can do C-c C-i on an symbol without the package specified, and it shows you a list of options in ido-mode to pick from. It greatly simplifies life, and I'll try sending another PR with that feature once this PR goes in.) |
e.g. (:import-from :foo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. As opposed to just looking at prefixes. Previously, If you had an existing defpackage like this:
(defpakage :foo
(:import-from :bar/car
:find)))
And you imported bar::position, you'll end up with something ugly like this:
(defpackage :foo
(:import-from :bar
:position/car
:find))