Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selection of preferred PowerShell version for Windows machines #16

Merged
merged 3 commits into from
May 4, 2021

Conversation

PiotrBaran1010
Copy link
@PiotrBaran1010 PiotrBaran1010 commented Dec 16, 2020

Similar functionality as in #15 but with changes suggested by @froque

Reference: https://issues.jenkins-ci.org/browse/JENKINS-52421

@froque
Copy link
Member
froque commented Dec 17, 2020

This a better PR than #15, but I'm afraid is still not what I was expecting.

With this PR I can choose PowerShell Version Preference between "Windows PowerShell" and "PowerShell Core" in global jenkins configuration (http://localhost:8080/jenkins/configure)
image

I was expecting to be able to configure each individual jenkins slave (http://localhost:8080/jenkins/computer/slave1/configure):
image

@PiotrBaran1010
Copy link
Author

Would it be ok to have one global setting that the slaves would inherit by default, with the option to override it for individual slaves? I have a pretty complex setup in which slaves are created and removed dynamically based on load and I wouldn't want to modify settings per slave in that case.

@froque
Copy link
Member
froque commented Jan 11, 2021

Would it be ok to have one global setting that the slaves would inherit by default, with the option to override it for individual slaves?

yes, that makes sense

@PiotrBaran1010
Copy link
Author

Hi, @froque
Pushed new changes according to your suggestions, please check. Thanks!

@marcohald
Copy link

Is there anything new to this PR ?
I would also need this

@froque froque merged commit 34a93ef into jenkinsci:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants