Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't handle safe mode or open_basedir #15

Closed
mapkyca opened this issue Dec 15, 2014 · 4 comments
Closed

Doesn't handle safe mode or open_basedir #15

mapkyca opened this issue Dec 15, 2014 · 4 comments

Comments

@mapkyca
Copy link
Contributor
mapkyca commented Dec 15, 2014

Basically, curl does some odd things in many hosted environments where basedir or safe mode are set - namely, CURLOPT_FOLLOWLOCATION is disabled... for some reason.

This causes problems on a number of hosts where this is enabled by default.

@benwerd's solution was to implement this in code, but that's not pretty in a library context. Perhaps having the ability to pass a send function to hand off to might be a way to go? I can of course just subclass...

(Refs idno/known#629)
mapkyca added a commit to mapkyca/mention-client-php that referenced this issue Dec 15, 2014
@mapkyca
Use static:: instead of self:: for get/post methods for easier overri…
de4ff23 
…ding. Refs indieweb#15.
@mapkyca mapkyca mentioned this issue Dec 15, 2014
Merged
mapkyca added a commit to mapkyca/idno that referenced this issue Dec 15, 2014
@mapkyca
Override Webmention client to use native webservices.
c50af63 
Refs: indieweb/mention-client-php#15 (requires)
Refs: idno#629
Refs: idno#614
@benwerd
Copy link
Contributor
benwerd commented Dec 17, 2014

Seconding this. We may subclass, but this is going to be an ongoing issue for people who use shared hosts, so it's worth considering a fix.

@mapkyca
Copy link
Contributor Author
mapkyca commented Dec 17, 2014

I sent a patch (#16) through that mods so get and post can be extended (change self to static + turn a few private methods to protected), this makes subclassing easier/possible so one can use one's own webservice calls to actually send things through.

Less than ideal, but maybe better than everyone under the sun implementing follow in code, which seems to be the implication of using curl or php's native fopen calls.

mapkyca added a commit to mapkyca/idno that referenced this issue Jan 15, 2015
@mapkyca
Override Webmention client to use native webservices.
378cb66 
Refs: indieweb/mention-client-php#15 (requires)
Refs: idno#629
Refs: idno#614
@aaronpk
Copy link
Member
aaronpk commented Oct 14, 2015

I assume this has been an acceptable solution so far? Is there anything else to resolve in this issue or can I close it?

@benwerd
Copy link
Contributor
benwerd commented Oct 14, 2015

All happy at this end!

@kylewm kylewm closed this as completed Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aaronpk @mapkyca @benwerd @kylewm