-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't handle safe mode or open_basedir #15
Comments
Refs: indieweb/mention-client-php#15 (requires) Refs: idno#629 Refs: idno#614
Seconding this. We may subclass, but this is going to be an ongoing issue for people who use shared hosts, so it's worth considering a fix. |
I sent a patch (#16) through that mods so get and post can be extended (change self to static + turn a few private methods to protected), this makes subclassing easier/possible so one can use one's own webservice calls to actually send things through. Less than ideal, but maybe better than everyone under the sun implementing follow in code, which seems to be the implication of using curl or php's native fopen calls. |
Refs: indieweb/mention-client-php#15 (requires) Refs: idno#629 Refs: idno#614
I assume this has been an acceptable solution so far? Is there anything else to resolve in this issue or can I close it? |
All happy at this end! |
Basically, curl does some odd things in many hosted environments where basedir or safe mode are set - namely, CURLOPT_FOLLOWLOCATION is disabled... for some reason.
This causes problems on a number of hosts where this is enabled by default.
@benwerd's solution was to implement this in code, but that's not pretty in a library context.
Perhaps having the ability to pass a send function to hand off to might be a way to go?I can of course just subclass...(Refs idno/known#629)
The text was updated successfully, but these errors were encountered: