-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_adjacency_submatrix #2379
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2379 +/- ##
=======================================
Coverage 84.31% 84.32%
=======================================
Files 380 380
Lines 62217 62254 +37
Branches 12207 12217 +10
=======================================
+ Hits 52461 52498 +37
Misses 9756 9756
Continue to review full report in Codecov by Sentry.
|
The time complexity of |
Either way, I suspect this will be too slow. Technically, this function will always take time proportional to the number of matrix elements due to This particular solution does as many edge lookups as the number of matrix elements, i.e. Nevertheless, this implementation is so simple that we can have high confidence in it. Thus let's use it to expand the tests before moving on to implementing a faster one. What I proposed in the issue using sorted intersections should take time So it will be useful to think about various types of applications. Will the submatrices be smaller or larger than the typical degree? |
@szhorvat So, am I right to assume in light of your comments that you are in favour of merging this PR even if you have concerns about the performance? @GroteGnoom is this still a draft or is it ready to be merged? |
No, I think we should fix the performance. It is not ready, loop edges are not handled. Although that would be easy with an And we need docs. |
I think they are? (the TODO can be removed I think) But it's still a mess, so I'll at least clean up first. And I don't mind looking at performance either. |
Sorry about that, I didn't look carefully enough. |
Also remove some commented out code.
16ec9e9
to
001b147
Compare
Fixes #2196